Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend/docker-compose: remove race condition and improve interactive dev experience #627

Merged
merged 2 commits into from
Dec 1, 2022

Commits on Nov 25, 2022

  1. backend/docker-compose: add pg dependency, optional persistence

    This change adds a dependency to the (nebraska) "server" service on the
    "postgres" service in docker-compose.test.yaml.
    Motivation of the change is to prevent a race condition where the
    "server" container starts faster than "postgres", fails to connect to
    the database, and shuts down.
    
    Additionally, an optional persistent storage for postgres is added.
    DB contents can be persisted across docker-compose runs to aid manual,
    interactive testing. Usage instructions have been added to the YAML
    files as comments. The local directory used for persiting postgres data
    has been added to .gitignore to prevent accidental commits.
    
    Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
    t-lo committed Nov 25, 2022
    Configuration menu
    Copy the full SHA
    f1f0704 View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2022

  1. backend/docker-compose.test.yaml: replace simple depends_on with serv…

    …ice restart
    
    Co-authored-by: Kai Lüke <pothos@users.noreply.github.com>
    t-lo and pothos committed Nov 30, 2022
    Configuration menu
    Copy the full SHA
    e9e93d7 View commit details
    Browse the repository at this point in the history