Reapply "Enable VA-API support in FreeRDP" & bump ffmpeg extension

[travier]

Reapply "Enable VA-API support in FreeRDP"

This reverts commit c70cec9.

---

Bump org.freedesktop.Platform.ffmpeg-full to 24.08

---

See: #81

[flathubbot]

Started test build 169009

[flathubbot]

Build 169009 successful
To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/152098/org.kde.krdc.flatpakref

[JoelleJS]

As mentioned in #81 this works on my PC (AMD GPU) but I'd like to test this one on two laptops of mine with other GPU brands/Linux distributions.

[travier]

Thanks for testing! I'll wait until you get back to us with results.

[JoelleJS]

I couldn't get VA-API working on NVIDIA on Linux Mint for the life of me (in general, not just in KRDC). So I only tested two laptops with Intel graphics. It works well.

The issue with out of bounds resolutions remains. As a workaround you can force software decoding by setting a bogus value for LIBVA_DRIVER_NAME, e.g. flatpak run --env="LIBVA_DRIVER_NAME=asdfg" org.kde.krdc.

Not ideal but perhaps acceptable given the benefits of hardware acceleration.

EDIT: I also had to manually install org.freedesktop.Platform.ffmpeg-full 24.08 because it kept using 23.08 without problem (or to be precise, with problem: VA-API was failing). Not sure whether it will autodownload when this is merged.

[twelho]

I've managed to test this with an Intel-based laptop connecting to a Windows 10 + NVIDIA setup. The video decoder does kick in, but there is some kind of major memory corruption happening, and view is basically completely garbled, flickering and overlays tiles from other applications. Haven't seen this with other applications using hardware decoding. Selecting "Disable All Acceleration" in the connection settings does however successfully disable hardware decoding and the picture is clean again. Maybe this could also work around the out of bounds resolution @JoelleJS ?

I also had version 24.08.3 with #42 still kicking around, same issues with that... Maybe I need to re-boot and check again. Or it could also be an issue of the RDP host.

[JoelleJS]

@twelho Using Disable All Acceleration makes the program not respond for a while and then output

[14:09:11:594] [2:2] [ERROR][com.freerdp.core.connection] - Timeout waiting for activation
KRDC: Unable to connect
kf.notifications: Failed to play sound with canberra: File or data not found
[14:09:13:327] [2:2] [ERROR][com.freerdp.core] - freerdp_abort_connect:freerdp_set_last_error_ex ERRCONNECT_CONNECT_CANCELLED [0x0002000B]

The remote is an Arch Linux machine running KRDP integrated in Plasma.

[twelho]

A reboot didn't fix it in my case, the picture still becomes brighter and brighter with hardware acceleration until it's completely white. In the debug log output I spotted the following lines:

[14:58:20:522] [2:2] [INFO][com.freerdp.gdi] - Local framebuffer format  PIXEL_FORMAT_RGBX32
[14:58:20:522] [2:2] [INFO][com.freerdp.gdi] - Remote framebuffer format PIXEL_FORMAT_BGRA32

So it might be, that the framebuffer format conversions are failing. Nevertheless, disabling hardware acceleration does fix it, so not a deal breaker in this case. No idea why it doesn't work without hwaccel for you @JoelleJS , seems quite strange that that would have an effect on the connetion. What is the RDP server exactly? AFAIK KDE's integrated tool for that is Krfb, but it doesn't support RDP, only VNC (at least on my machine).

[JoelleJS]

@twelho It wasn't properly announced but the remote desktop functionality in the Plasma system settings is backed by KRDP since Plasma 6.1.