feat: implement efficient(-ish) change detection for PolygonLayer
& PolylineLayer
#1904
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main aim of this change is to enable each element to update independently only when required.
The pre-projection and pre-simplification logic have been refactored into their own state which can be mixed in (and is to
PolylineLayer
andPolygonLayer
).Performance results:
Additionally, this fixes #1894. Unless
useDynamicUpdate
is disabled, in which case,Key
s have been recommended to refresh the widget manually. This approach has been recommended in some cases: see the in-code docs.The default
simplificationTolerance
has also been lowered to 0.3. This gives perfectly acceptable performance (very similar to 0.5 as before), but reduced visual artifacts.