fix!: added integer tileDimension & deprecated tileSize
#1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor documentation improvements
|
We'll leave this to review and merge before a major upgrade. |
josxha
previously approved these changes
Sep 12, 2024
|
As a way of making this less breaking, you could deprecate |
I don't see why that wouldn't work, I'd be happy to do that if you think that's better. |
Deprecated `TileLayer.tileSize` & made nullable Reflected new name throughout internals and semi-internals
JaffaKetchup
changed the title
tileSize to integertileDimension replacing deprecated tileSize
JaffaKetchup
changed the title
tileDimension replacing deprecated tileSizetileDimension & deprecated tileSize
JaffaKetchup
dismissed
josxha’s stale review
Implementation significantly changed
|
I've done what @TesteurManiak suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1936.
There's no apparent reason that
tileSizewould be anything but an integer, since it is not possible to get tiles in fractional pixels. The WMS layer already assumed this. This PR relies on this assumption, and a different fix would be needed for #1936 if this assumption is not valid.This is breaking, particularly for those using more internal functionality. However, for most users, it should not be breaking. Those which are using
tileSizeexplicitly currently will have a deprecation message, but functionality will not change. Additionally, the 'temporary' fix for #1936 (just converting the number to an integer before a string) is also implemented if not using the newtileDimension.