Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config for 'No team' #51

Merged
merged 14 commits into from
Sep 25, 2024
Merged

Conversation

lucasmrod
Copy link
Member

@lucasmrod lucasmrod commented Sep 24, 2024

Just adding the "No team" file.

default.yml Outdated

policies:
queries:
agent_options:
path: ./lib/agent-options.yml
controls:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we remove controls, how will the Fleet Free user add configuration profiles?

Maybe we instruction Fleet Premium users only to remove controls?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I forgot about Fleet Free, we can leave it here empty.

Copy link
Member

@noahtalerman noahtalerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

Yes, I think it makes sense to remove the software and policies. And put them in dogfood instead. We've learned that this gitops repo gets out of date fast. One more spot to maintain.

We can always point folks to our dogfood it-and-security/ folder. It's public!

@lucasmrod lucasmrod changed the title Add config for 'No team' and sample packages Add config for 'No team' Sep 24, 2024
@@ -0,0 +1,10 @@
# Teams are available in Fleet Premium.

# This file updates policies, controls, and software for hosts assigned to "No team."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lucasmrod is it true that we only support policies, controls, and software for "No team"? (no queries or agent options yet)

And, queries and agent options for hosts on "No team" are controlled at the global (default.yml) level.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Queries: We don't support queries for "No team", so, queries defined in default.yml are global queries.
  • Agent options: Agent options for "No team" hosts are defined in default.yml (in the future we could move this to teams/no-team.yml). On this iteration Marko adviced (in the Figma designs) to throw a warning if the user is setting agent_options or queries in teams/no-team.yml (they will be ignored).

Copy link
Member

@noahtalerman noahtalerman Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Thanks :)

I updated the help text (comments at the top of each file) to be explicit. Please let me know if those doesn't look right so we can follow up in a quick PR.

Copy link
Member

@noahtalerman noahtalerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lucasmrod I took a pass that the comment section in the default.yml and teams/ YAML files to make them consistent and explicit.

When you get the chance, please take a look to see if they're accurate. Thanks!

@lucasmrod
Copy link
Member Author

When you get the chance, please take a look to see if they're accurate. Thanks!

@noahtalerman Changes look good!

@noahtalerman noahtalerman dismissed their stale review September 25, 2024 16:12

Feedback addressed

@noahtalerman noahtalerman merged commit fff6ca4 into main Sep 25, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants