-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for 'No team' #51
Conversation
default.yml
Outdated
|
||
policies: | ||
queries: | ||
agent_options: | ||
path: ./lib/agent-options.yml | ||
controls: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we remove controls, how will the Fleet Free user add configuration profiles?
Maybe we instruction Fleet Premium users only to remove controls
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, I forgot about Fleet Free, we can leave it here empty.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Yes, I think it makes sense to remove the software and policies. And put them in dogfood instead. We've learned that this gitops repo gets out of date fast. One more spot to maintain.
We can always point folks to our dogfood it-and-security/
folder. It's public!
@@ -0,0 +1,10 @@ | |||
# Teams are available in Fleet Premium. | |||
|
|||
# This file updates policies, controls, and software for hosts assigned to "No team." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lucasmrod is it true that we only support policies, controls, and software for "No team"? (no queries or agent options yet)
And, queries and agent options for hosts on "No team" are controlled at the global (default.yml) level.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Queries: We don't support queries for "No team", so, queries defined in
default.yml
are global queries. - Agent options: Agent options for "No team" hosts are defined in
default.yml
(in the future we could move this toteams/no-team.yml
). On this iteration Marko adviced (in the Figma designs) to throw a warning if the user is settingagent_options
orqueries
inteams/no-team.yml
(they will be ignored).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it! Thanks :)
I updated the help text (comments at the top of each file) to be explicit. Please let me know if those doesn't look right so we can follow up in a quick PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lucasmrod I took a pass that the comment section in the default.yml and teams/ YAML files to make them consistent and explicit.
When you get the chance, please take a look to see if they're accurate. Thanks!
@noahtalerman Changes look good! |
Just adding the "No team" file.