Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise error early when port source is snapped into PML #1895

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

weiliangjin2021
Copy link
Collaborator

No description provided.

@QimingFlex
Copy link
Contributor

Thanks, @weiliangjin2021 ! I tested it, and it looks great. I have one suggestion regarding the error message: could we provide more detailed instructions? For example:

Port {port.name} normal is less than 2 cells to the boundary on the +{'xyz'[normal_axis]} side. Please either increase the mesh resolution near the port or move the port away from the boundary.

@weiliangjin2021
Copy link
Collaborator Author

Thanks, @weiliangjin2021 ! I tested it, and it looks great. I have one suggestion regarding the error message: could we provide more detailed instructions? For example:

Port {port.name} normal is less than 2 cells to the boundary on the +{'xyz'[normal_axis]} side. Please either increase the mesh resolution near the port or move the port away from the boundary.

Good point!

@weiliangjin2021 weiliangjin2021 merged commit 89e8491 into pre/2.8 Aug 9, 2024
15 of 16 checks passed
@weiliangjin2021 weiliangjin2021 deleted the weiliang/port branch August 9, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants