Merge pull request #949 from flexion/separate-tests

separate petition contact tests into valid/invalid
flexion · Feb 26, 2019 · 2896bb9 · 2896bb9
2 parents 846a72e + d05a643
commit 2896bb9
Showing 1 changed file with 24 additions and 7 deletions.
diff --git a/shared/src/business/entities/Contacts/PetitionContacts.test.js b/shared/src/business/entities/Contacts/PetitionContacts.test.js
@@ -141,7 +141,7 @@ describe('Petition', () => {
     expect(petition.isValid()).toEqual(true);
   });
 
-  it('can validate Partnership (BBA Regime) contact', () => {
+  it('can validate invalid Partnership (BBA Regime) contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -153,6 +153,9 @@ describe('Petition', () => {
       partyType: 'Partnership (BBA Regime)',
     });
     expect(petition.isValid()).toEqual(false);
+  });
+
+  it('can validate valid Partnership (BBA Regime) contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -185,7 +188,7 @@ describe('Petition', () => {
     expect(petition.isValid()).toEqual(true);
   });
 
-  it('can validate Trust', () => {
+  it('can validate invalid Trust contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -197,6 +200,9 @@ describe('Petition', () => {
       partyType: 'Trust',
     });
     expect(petition.isValid()).toEqual(false);
+  });
+
+  it('can validate valid Trust contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -229,7 +235,7 @@ describe('Petition', () => {
     expect(petition.isValid()).toEqual(true);
   });
 
-  it('can validate Conservator contact', () => {
+  it('can validate invalid Conservator contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -241,6 +247,9 @@ describe('Petition', () => {
       partyType: 'Conservator',
     });
     expect(petition.isValid()).toEqual(false);
+  });
+
+  it('can validate valid Conservator contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -273,7 +282,7 @@ describe('Petition', () => {
     expect(petition.isValid()).toEqual(true);
   });
 
-  it('can validate Guardian contact', () => {
+  it('can validate invalid Guardian contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -285,7 +294,9 @@ describe('Petition', () => {
       partyType: 'Guardian',
     });
     expect(petition.isValid()).toEqual(false);
+  });
 
+  it('can validate valid Guardian contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -318,7 +329,7 @@ describe('Petition', () => {
     expect(petition.isValid()).toEqual(true);
   });
 
-  it('can validate Custodian contact', () => {
+  it('can validate invalid Custodian contact', () => {
     let petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -330,7 +341,9 @@ describe('Petition', () => {
       partyType: 'Custodian',
     });
     expect(petition.isValid()).toEqual(false);
+  });
 
+  it('can validate valid Custodian contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -363,7 +376,7 @@ describe('Petition', () => {
     expect(petition.isValid()).toEqual(true);
   });
 
-  it('can validate Donor contact', () => {
+  it('can validate invalid Donor contact', () => {
     let petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -375,7 +388,9 @@ describe('Petition', () => {
       partyType: 'Donor',
     });
     expect(petition.isValid()).toEqual(false);
+  });
 
+  it('can validate valid Donor contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -399,7 +414,7 @@ describe('Petition', () => {
     expect(petition.isValid()).toEqual(true);
   });
 
-  it('can validate Transferee contact', () => {
+  it('can validate invalid Transferee contact', () => {
     let petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',
@@ -411,7 +426,9 @@ describe('Petition', () => {
       partyType: 'Transferee',
     });
     expect(petition.isValid()).toEqual(false);
+  });
 
+  it('can validate valid Transferee contact', () => {
     petition = new Petition({
       caseType: 'other',
       procedureType: 'Small',