Merge pull request #1479 from flexion/code-review-fixes

Code review comments addressed

README.md

@@ -1,7 +1,14 @@
 # Electronic Filing / Case Management System
 
 ### Build Status
-[![CircleCI](https://circleci.com/gh/flexion/ef-cms/tree/develop.svg?style=svg)](https://circleci.com/gh/flexion/ef-cms/tree/develop)
+
+#### develop
+
+[![CircleCI](https://circleci.com/gh/flexion/ef-cms/tree/develop.svg?style=svg)](https://circleci.com/gh/flexion/ef-cms/tree/develop) 
+
+#### staging
+
+[![CircleCI](https://circleci.com/gh/usataxcourt/ef-cms/tree/staging.svg?style=svg)](https://circleci.com/gh/usataxcourt/ef-cms/tree/staging) 
 
 API | Front-End | Shared Code
 --- | --------- | -----------
@@ -216,4 +223,4 @@ Follow these steps for creating the end of sprint PRs for the court.
      - UI_SONAR_TOKEN (the token for the sonar UI project)
      - COGNITO_SUFFIX (a suffix of your choice for the cognito url)
      - USTC_ADMIN_PASS (a unique password of your choice used by the cognito admin user)
-8. You're good to go.  Builds should start running and deploying if everything is setup correctly.
+8. You're good to go.  Builds should start running and deploying if everything is setup correctly.

shared/src/business/useCases/addCoverToPDFDocumentInteractor.test.js

@@ -8,6 +8,7 @@ const { PDFDocumentFactory } = require('pdf-lib');
 const testAssetsPath = path.join(__dirname, '../../../test-assets/');
 
 function testPdfDocBytes() {
+  // sample.pdf is a 1 page document
   return fs.readFileSync(testAssetsPath + 'sample.pdf');
 }
 

shared/src/tools/generateCategories.js

@@ -1,3 +1,9 @@
+/**
+ * This is a convenience utility for converting an Event Code CSV from the court
+ * to a JSON file that can be used by the application. It may never be used
+ * again, but we've kept it in the project just in case.
+ */
+
 const _ = require('lodash');
 const fs = require('fs');
 const parse = require('csv-parse');