Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subcommand to objects to pass back to creators #29

Merged
merged 4 commits into from
Jan 21, 2019
Merged

Add subcommand to objects to pass back to creators #29

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cf2536f
Initial cut at creator subcommand.
resuna Aug 17, 2018
23be2fc
make output_queue_length specific
resuna Aug 22, 2018
81cad5c
Declare kafkatcl_handleObjectObjCmd
resuna Aug 22, 2018
a9deb8b
Merge branch 'master' into creator-subcommand
resuna Nov 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion generic/kafkatcl.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ kafkatcl_subscriber_poll(kafkatcl_handleClientData *kh);
void
kafkatcl_consume_stop_all_partitions (kafkatcl_topicClientData *kt);

int
kafkatcl_handleObjectObjCmd(ClientData cData, Tcl_Interp *interp, int objc, Tcl_Obj *CONST objv[]);

// DEBUG
#ifdef DEBUGPRINTF
void kafkatcl_dump_topic_partition_list(rd_kafka_topic_partition_list_t *topics)
Expand Down Expand Up @@ -2160,13 +2163,15 @@ kafkatcl_handle_topic_info (Tcl_Interp *interp, kafkatcl_topicClientData *kt, in
"name",
"partitions",
"consistent_partition",
"output_queue_length",
NULL
};

enum subOptions {
SUBOPT_NAME,
SUBOPT_PARTITIONS,
SUBOPT_CONSISTENT_PARTITION
SUBOPT_CONSISTENT_PARTITION,
SUBOPT_OUTPUT_QUEUE_LENGTH
};

// argument must be one of the subOptions defined above
Expand Down Expand Up @@ -2229,6 +2234,16 @@ kafkatcl_handle_topic_info (Tcl_Interp *interp, kafkatcl_topicClientData *kt, in
Tcl_SetObjResult (interp, Tcl_NewIntObj (whichPartition));
break;
}

case SUBOPT_OUTPUT_QUEUE_LENGTH: {
if (objc != 3) {
Tcl_WrongNumArgs (interp, 3, objv, "");
return TCL_ERROR;
}

Tcl_SetObjResult (interp, Tcl_NewIntObj (rd_kafka_outq_len (kh->rk)));
break;
}
}
return TCL_OK;
}
Expand Down Expand Up @@ -2530,6 +2545,7 @@ kafkatcl_topicConsumerObjectObjCmd(ClientData cData, Tcl_Interp *interp, int obj
"start",
"start_queue",
"stop",
"creator",
"delete",
"consume_start",
"consume_start_queue",
Expand All @@ -2544,6 +2560,7 @@ kafkatcl_topicConsumerObjectObjCmd(ClientData cData, Tcl_Interp *interp, int obj
OPT_CONSUME_START,
OPT_CONSUME_START_QUEUE,
OPT_CONSUME_STOP,
OPT_CREATOR,
OPT_DELETE,
OPT_LEGACY_CONSUME_START,
OPT_LEGACY_CONSUME_START_QUEUE,
Expand Down Expand Up @@ -2670,6 +2687,10 @@ kafkatcl_topicConsumerObjectObjCmd(ClientData cData, Tcl_Interp *interp, int obj
break;
}

case OPT_CREATOR: {
return kafkatcl_handleObjectObjCmd(kt->kh, interp, objc-1, objv+1);
}

case OPT_INFO: {
return kafkatcl_handle_topic_info (interp, kt, objc, objv);
}
Expand Down Expand Up @@ -2800,6 +2821,7 @@ kafkatcl_topicProducerObjectObjCmd(ClientData cData, Tcl_Interp *interp, int obj
"produce",
"produce_batch",
"info",
"creator",
"delete",
NULL
};
Expand All @@ -2808,6 +2830,7 @@ kafkatcl_topicProducerObjectObjCmd(ClientData cData, Tcl_Interp *interp, int obj
OPT_PRODUCE,
OPT_PRODUCE_BATCH,
OPT_INFO,
OPT_CREATOR,
OPT_DELETE
};

Expand Down Expand Up @@ -2924,6 +2947,10 @@ kafkatcl_topicProducerObjectObjCmd(ClientData cData, Tcl_Interp *interp, int obj
break;
}

case OPT_CREATOR: {
return kafkatcl_handleObjectObjCmd(kt->kh, interp, objc-1, objv+1);
}

case OPT_INFO: {
return kafkatcl_handle_topic_info (interp, kt, objc, objv);
}
Expand Down