fix(export): display a better error for missing segments and don't hide them in ui #3527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
them in ui. Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
erka
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3527 +/- ##
=======================================
Coverage 65.76% 65.76%
=======================================
Files 169 169
Lines 13651 13651
=======================================
Hits 8977 8977
Misses 3989 3989
Partials 685 685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
markphelps
reviewed
Oct 11, 2024
Co-authored-by: Mark Phelps <209477+markphelps@users.noreply.github.com> Signed-off-by: Roman Dmytrenko <rdmytrenko@gmail.com>
erka
force-pushed
the
flag-rule-segments
branch
from
94c3e35
to
8107f4e
Compare
markphelps
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related #3417
This isn't a fix for the original problem but improvement for people to see the problem and fix it.