perf(GoogleDrive, WebDav): Don't loop through all lines when finding …

…highest ID Signed-off-by: Marcel Klehr <mklehr@gmx.net>
floccusaddon · Jul 6, 2024 · 20a2426 · 20a2426
1 parent 96c8cb8
commit 20a2426
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/src/lib/adapters/GoogleDrive.ts b/src/lib/adapters/GoogleDrive.ts
@@ -249,14 +249,15 @@ export default class GoogleDriveAdapter extends CachingAdapter {
 
       /* let's get the highestId */
       const byNL = xmlDocText.split('\n')
-      byNL.forEach(line => {
+      for (const line of byNL) {
         if (line.indexOf('<!--- highestId :') >= 0) {
           const idxStart = line.indexOf(':') + 1
           const idxEnd = line.lastIndexOf(':')
 
           this.highestId = parseInt(line.substring(idxStart, idxEnd))
+          break
         }
-      })
+      }
 
       this.bookmarksCache = XbelSerializer.deserialize(xmlDocText)
       if (this.lockingInterval) {

diff --git a/src/lib/adapters/WebDav.ts b/src/lib/adapters/WebDav.ts
@@ -224,14 +224,15 @@ export default class WebDavAdapter extends CachingAdapter {
 
       /* let's get the highestId */
       const byNL = xmlDocText.split('\n')
-      byNL.forEach(line => {
+      for (const line of byNL) {
         if (line.indexOf('<!--- highestId :') >= 0) {
           const idxStart = line.indexOf(':') + 1
           const idxEnd = line.lastIndexOf(':')
 
           this.highestId = parseInt(line.substring(idxStart, idxEnd))
+          break
         }
-      })
+      }
 
       switch (this.server.bookmark_file_type) {
         case 'xbel':