fix(Controller logic): Catch all 'Receiving end does not exist' errors

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
floccusaddon · Jul 18, 2024 · 5133823 · 5133823
1 parent 1daa182
commit 5133823
Show file tree

Hide file tree

Showing 2 changed files with 33 additions and 5 deletions.
diff --git a/src/lib/Controller.ts b/src/lib/Controller.ts
@@ -45,10 +45,26 @@ export default class Controller implements IController {
     if (Capacitor.getPlatform() === 'web') {
       const browser = (await import('../lib/browser-api')).default
       return {
-        postMessage: (data) => browser.runtime.sendMessage(data),
+        postMessage: (data) => {
+          try {
+            browser.runtime.sendMessage(data)
+          } catch (e) {
+            console.warn(e)
+          }
+        },
         addEventListener: (fn) => {
-          browser.runtime.onMessage.addListener(fn)
-          return () => browser.runtime.onMessage.removeListener(fn)
+          try {
+            browser.runtime.onMessage.addListener(fn)
+          } catch (e) {
+            console.warn(e)
+          }
+          return () => {
+            try {
+              browser.runtime.onMessage.removeListener(fn)
+            } catch (e) {
+              console.warn(e)
+            }
+          }
         },
       }
     }

diff --git a/src/lib/browser/BrowserController.js b/src/lib/browser/BrowserController.js
@@ -141,12 +141,24 @@ export default class BrowserController {
     if (!navigator.userAgent.includes('Firefox') && typeof WorkerGlobalScope !== 'undefined' && self instanceof WorkerGlobalScope) {
       addEventListener('message', (event) => this._receiveEvent(event.data, (data) => event.source.postMessage(data)))
     } else {
-      browser.runtime.onMessage.addListener((data) => void (this._receiveEvent(data, (data) => browser.runtime.sendMessage(data))))
+      browser.runtime.onMessage.addListener((data) => void (this._receiveEvent(data, (data) => {
+        try {
+          browser.runtime.sendMessage(data)
+        } catch (e) {
+          console.warn(e)
+        }
+      })))
     }
     this.onStatusChange(async() => {
       if (self?.clients) {
         const clientList = await self.clients.matchAll()
-        clientList.forEach(client => client.postMessage({ type: 'status:update', params: [] }))
+        clientList.forEach(client => {
+          try {
+            client.postMessage({ type: 'status:update', params: [] })
+          } catch (e) {
+            console.warn(e)
+          }
+        })
       } else {
         try {
           await browser.runtime.sendMessage({ type: 'status:update', params: [] })