-
Notifications
You must be signed in to change notification settings - Fork 501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add .WASM support for Jai bindgen #1128
Conversation
|
Apologies for not responding yet. I'll try to set aside a day over the weekend to look into PRs. |
PS looks like that failed CI run was some unrelated networking hickup:
|
Sorry, should have merged that PR sooner, since it's a trivial update. I really need to catch up a bit on PRs :) Btw something unrelated: I'm now at a point where I'd need to contribute to https://github.com/colinbellino/sokol-jai (because there's a API breaking change in the pipeline which requires updating the shaders and samples. It will look similar to this: kassane/sokol-d#31 I wonder if it makes sense if you give me a couple of rights for the https://github.com/colinbellino/sokol-jai repo, just enough to create branches and PRs. That will make it a bit simpler to create PRs without having to maintain my own fork (I would still do regular PRs for you to review and not commit directly into main, but at least I wouldn't need to maintain my own fork). Also, I still haven't tried yet to get into the Jai Beta, that would also make a couple of things easier :D I will probably need to do a "blind" PR at first which might not actually build and need some fixups (e.g. I might need your help for that). |
Thanks for merging this ;) I can probably do the update to colinbellino/sokol-jai, is the incoming change documented somewhere? (just came back from vacations, haven't really dug into this yet). (For the beta if you want to get in at some point, do let me know in private. I'm sure we can figure something out with Jon.) |
Thanks for adding me. I'll create a draft PR with more info, but in general the things that need to be fixed in the sample code:
...but as I said, I'll try to apply those changes blindly, and the time to merge this stuff is also still a bit out (I'm working checkbox by checkbox though this checklist: #1111) |
I'm putting together a JAI + WASM example, so i thought i'd update the bindgen for Jai while i'm at it ;)
The corresponding commit in sokol-jai: colinbellino/sokol-jai@4a679fd