Make TileProvider an interface (or: maybe this is just an FYI rather than a PR...) #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had to fork
go-staticmaps
and change the defaultTileProvider
struct in to an interface (and update things accordingly) in order to it with so-called "rasterzen" tiles:https://github.com/whosonfirst/go-rasterzen
These are (Nextzen) vector tiles by default that get rendered in SVG/PNG tiles in code so the default model of fetching a URL (in
tile_fetcher.go
) and decoding the bytes doesn't work for rasterzen tiles. It's also meant moving the actual HTTP request in the tile provider which is maybe messier than you'd like:https://github.com/whosonfirst/go-whosonfirst-staticmaps/blob/rasterzen/provider/rasterzen.go
Anyway, I just wanted to mention that there was a need to do this. If there's a different/better way to accomplish the same thing then I am happy enough to change my code.
The end result is this:
https://github.com/whosonfirst/go-whosonfirst-staticmaps/tree/rasterzen#wof-staticmap
Also, thanks for writing
go-staticmaps
in the first place :-)