Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Update primary color #115

Closed
wants to merge 8 commits into from
Closed

Feat: Update primary color #115

wants to merge 8 commits into from

Conversation

Biowulf21
Copy link
Contributor

Hello @sadespresso, I have refactored my code to implement #105. Please do check it out.

I have found a small quirk with regards to keeping the primary color on the local storage though. Android seems to backup local storage - and by extension, the primary color - for devices with android API >= 23 even after uninstalls. There is a way to clear them by editing the AndroidManifest.xml file.

Let me know what your preference is with regards to this.

Thanks!

@sadespresso
Copy link
Collaborator

sadespresso commented Mar 28, 2024

So there are several problems we have now:

  • The bottom navigation color is somehow inverted
  • As you can see in the picture below, the primary color does not have enough contrast with the background
  • Secondary color is not same hue as the primary color
  • The default primary color is not Flow's brand color
  • It's not really good idea to specify colors in each widgets when we can set it on the theme.

simulator_screenshot_28BF989C-30A0-4E65-8816-8CADE1F8477C

I think it's better to dynamically generate the color scheme, and reconstruct the theme from it.

I also think there are so many things need to be reconsidered before making any more progress.

Again, thank you for the implementation ^^

@sadespresso sadespresso closed this Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants