FDN-2062: Add support for Postgres 15 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Postgres 15, the `pg_class` table does not have `relhasoids`, so Partman's code from this repository does not work in Postgres 15. None of our tables were created WITH OIDS, according to the query shown here and grepping the source code, so just removing the part that checks for OIDS will work. (This code that I'm removing hasn't been completely removed in recent versions of Partman, but it is guarded by a version check.) The change to `journal.quote_column` reflects type changes from Postgres 11 to Postgres 15, but also works against Postgres 11 (as in, this package still builds fine against PG 11 with this change). The install script needs to grant permissions to the public schema in Postgres 15. An additional `Dockerfile-15` has been added to create a Postgres 15 based image. The Travis configuration has been updated to build that image. New scripts have been added to recreate the modified functions in production: - `journal.quote_column` - `partman.create_partition_id` - `partman.create_partition_time` [so]: https://stackoverflow.com/questions/70257495/postgresql-how-can-i-check-if-table-was-created-with-oids
gheine
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Postgres 15, the
pg_classtable does not haverelhasoids, soPartman's code from this repository does not work in Postgres 15.
None of our tables were created WITH OIDS, according to the query
shown here and grepping the source code, so just removing the part
that checks for OIDS will work. (This code that I'm removing hasn't
been completely removed in recent versions of Partman, but it is
guarded by a version check.)
The change to
journal.quote_columnreflects type changes fromPostgres 11 to Postgres 15, but also works against Postgres 11 (as
in, this package still builds fine against PG 11 with this change).
The install script needs to grant permissions to the public schema
in Postgres 15.
An additional
Dockerfile-15has been added to create a Postgres 15based image. The Travis configuration has been updated to build that
image.
New scripts have been added to recreate the modified functions in
production:
journal.quote_columnpartman.create_partition_idpartman.create_partition_time