Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PAY-3830: Updated readme #124

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

PAY-3830: Updated readme #124

wants to merge 2 commits into from

Conversation

SvetaNesterenko
Copy link
Contributor

No description provided.

pragatid29
pragatid29 previously approved these changes Aug 23, 2024
View reviewed changes
pmlemos
pmlemos reviewed Aug 23, 2024
View reviewed changes
Copy link

@pmlemos pmlemos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good... would you mind adding a link to the notion document, since it does seem to be related to this repo. :)

@themichaelyan
Copy link
Contributor

@SvetaNesterenko do we have any documentation on uploading logos to CDN? If not, maybe add it there as well.

@SvetaNesterenko
Copy link
Contributor Author

@SvetaNesterenko do we have any documentation on uploading logos to CDN? If not, maybe add it there as well.

I did not find it, but I don't think this Readme is a good place to add it

@themichaelyan
Copy link
Contributor

@SvetaNesterenko do we have any documentation on uploading logos to CDN? If not, maybe add it there as well.

I did not find it, but I don't think this Readme is a good place to add it

How about creating a Notion page for it?

@SvetaNesterenko
Copy link
Contributor Author

@SvetaNesterenko do we have any documentation on uploading logos to CDN? If not, maybe add it there as well.

I did not find it, but I don't think this Readme is a good place to add it

How about creating a Notion page for it?

can be done separately from this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmlemos pmlemos pmlemos left review comments

@themichaelyan themichaelyan themichaelyan approved these changes

@pragatid29 pragatid29 pragatid29 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SvetaNesterenko @themichaelyan @pmlemos @pragatid29