FDN-???: Support internal host names in PCI #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arias-m
approved these changes
Aug 15, 2024
arias-m
reviewed
Aug 15, 2024
| }.fold(_ => publicHost, _ => s"http://$applicationId") | ||
| val future = Future.find(Seq( | ||
| asyncDnsLookupByName(applicationId), | ||
| asyncDnsLookupByName(s"$applicationId.$applicationId"), |
There was a problem hiding this comment.
Could we make the namespace ID configurable?
We run same service payment in 2 different namespaces to avoid coupling stuff and minimise impact.
It would be better if we could configure the namespace Id and all the call within one cluster will go to the same service, which is the default one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.