Use rb_io_descriptor() API to fix deprecated message #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Ruby 3.4, it marks as deprecated that it use `fptr->fd` directly. Ref. ruby/ruby@b4d73e9 ```sh $ gem install capng_c --verbose ...(snip)... capng.c: In function 'rb_capng_get_caps_file': capng.c:511:3: warning: 'fd' is deprecated: rb_io_descriptor [-Wdeprecated-declarations] 511 | fd = fptr->fd; | ^~ In file included from ./capng.h:19, from capng.c:14: /home/watson/.rbenv/versions/3.4.1/include/ruby-3.4.0/ruby/io.h:154:9: note: declared here 154 | int fd; | ^~ capng.c: In function 'rb_capng_apply_caps_file': capng.c:541:3: warning: 'fd' is deprecated: rb_io_descriptor [-Wdeprecated-declarations] 541 | fd = fptr->fd; | ^~ /home/watson/.rbenv/versions/3.4.1/include/ruby-3.4.0/ruby/io.h:154:9: note: declared here 154 | int fd; | ^~ At top level: ...(snip)... ``` So, this patch will use `rb_io_descriptor()` instead of `fptr->fd` if available. Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
rb_io_descriptor
branch
from
bcbe42f to
8f0c3ac
Compare
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
rb_io_descriptor
branch
from
11c4b90 to
1df1fd2
Compare
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
Watson1978
force-pushed
the
rb_io_descriptor
branch
from
7b12fa9 to
7928bf1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Ruby 3.4, it marks as deprecated that it use
fptr->fddirectly.Ref. ruby/ruby@b4d73e9
So, this patch will use
rb_io_descriptor()instead offptr->fdif available.