Proposing the use of custom Queue implementation for message event mode #174
+66
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 25, 2020 10:31
Signed-off-by: Thiago Santos <thiago.santos@maxmilhas.com.br>
Signed-off-by: Thiago Santos <thiago.santos@maxmilhas.com.br>
Signed-off-by: Thiago Santos <thiago.santos@maxmilhas.com.br>
Signed-off-by: Thiago Santos <thiago.santos@maxmilhas.com.br>
|
I changed the package version of mocha from "*" to "^6.0.0" because last versions of mocha doesn't supports v8.x and v10.x of node, so, the configured pipeline would not work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As array.shift needs to reindex the whole array for each execution, this can be pretty processing expensive if you need to do it in a high frequency.
Though a custom Queue implementation will loose to native array shift in cases where there is not much items to deal with, the difference of time in this cases seems to be irrelevant.
So, it is worth it to use a custom Queue implementation to have a faster and less cpu demanding shift processing.
There is a lot of Queue implementations out there, I just choose one of them with a simple implementation and more array like for this PR.