reproduce flow with failing test

fluentassertions · Aug 21, 2023 · d68e26d · d68e26d
1 parent 59d35c3
commit d68e26d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 16 deletions.
diff --git a/src/FluentAssertions.Analyzers.Tests/Tips/SanityTests.cs b/src/FluentAssertions.Analyzers.Tests/Tips/SanityTests.cs
@@ -326,12 +326,20 @@ public class TestClass
 {
     public static void Main()
     {
-        var x = new TestType();
-        x.List.Any().Should().BeTrue();
+        var x = new TestType1();
+        x.Prop1.Prop2.List.Any().Should().BeTrue();
     }
 }
 
-public class TestType
+public class TestType1
+{
+    public TestType2 Prop1 { get; set; }
+}
+public class TestType2
+{
+    public TestType3 Prop2 { get; set; }
+}
+public class TestType3
 {
     public List<int> List { get; set; }
 }";

diff --git a/src/FluentAssertions.Analyzers/Utilities/VariableNameExtractor.cs b/src/FluentAssertions.Analyzers/Utilities/VariableNameExtractor.cs
@@ -1,15 +1,18 @@
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 using Microsoft.CodeAnalysis.CSharp;
 using Microsoft.CodeAnalysis;
+using System.Collections.Generic;
 
 namespace FluentAssertions.Analyzers
 {
     public class VariableNameExtractor : CSharpSyntaxWalker
     {
         private readonly SemanticModel _semanticModel;
 
-        public string VariableName { get; private set; }
-        public IdentifierNameSyntax VariableIdentifierName { get; private set; }
+        public string VariableName => VariableIdentifierName?.Identifier.Text;
+        public IdentifierNameSyntax VariableIdentifierName => PropertiesAccessed.Count > 0 ? PropertiesAccessed[0] : null;
+
+        public List<IdentifierNameSyntax> PropertiesAccessed { get; } = new List<IdentifierNameSyntax>();
 
         public VariableNameExtractor(SemanticModel semanticModel = null)
         {
@@ -20,17 +23,7 @@ public override void VisitIdentifierName(IdentifierNameSyntax node)
         {
             if (IsVariable(node))
             {
-                VariableName = node.Identifier.Text;
-                VariableIdentifierName = node;
-            }
-        }
-
-        public override void Visit(SyntaxNode node)
-        {
-            // the first identifier encountered will be the one at the bottom of the syntax tree
-            if (VariableName == null)
-            {
-                base.Visit(node);
+                PropertiesAccessed.Add(node);
             }
         }