Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support nullable types #217

Merged
merged 5 commits into from
Sep 1, 2023
Merged

feat: support nullable types #217

merged 5 commits into from
Sep 1, 2023

Conversation

Meir017
Copy link
Member

@Meir017 Meir017 commented Aug 27, 2023

No description provided.

@Meir017
Copy link
Member Author

Meir017 commented Aug 27, 2023

@melotic is it possible that codeql modifies the code to make unmarked properties nullable and then compiles again?

public Uri? DownloadUrl { get; set; }

public string? Hash { get; set; }
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@melotic making these nullable reproduced the issue

@Meir017 Meir017 changed the title reproduce #215 feat: support nullable types Aug 29, 2023
@Meir017 Meir017 merged commit 54a04cc into main Sep 1, 2023
6 checks passed
@Meir017 Meir017 deleted the bugfix-issue-215 branch September 1, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant