Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix group headers positionning #722

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

marienfressinaud
Copy link
Member

@marienfressinaud marienfressinaud commented Oct 31, 2024

The previous hack didn't work as expected for the collections and feeds groups. After a certain number of groups, the header passed behind the cards.

There is still an issue on mobile: if you open the actions menu of a date group (not the first) and that you scroll up, the menu will appear behind the headers. That's however a bit less problematic. Also, I plan to change the popups behaviour by not fixing them to the screen.

Pull request checklist:

  • code is manually tested
  • interface works on both mobiles and big screens
  • accessibility has been tested
  • tests are updated
  • French locale is synchronized
  • documentation is updated (including comments, commit messages, migration notes, …)

If you think one of the item isn’t applicable to the PR, please check it
anyway and precise N/A next to it.

The previous hack didn't work as expected for the collections and feeds
groups. After a certain number of groups, the header passed behind the
cards.

There is still an issue on mobile: if you open the actions menu of a
date group (not the first) and that you scroll up, the menu will appear
behind the headers. That's however a bit less problematic. Also, I plan
to change the popups behaviour by not fixing them to the screen.
@marienfressinaud marienfressinaud merged commit dffbdd6 into main Oct 31, 2024
4 checks passed
@marienfressinaud marienfressinaud deleted the fix/group-z-index branch October 31, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant