Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Generate correct links to tags in Atom feeds #728

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

marienfressinaud
Copy link
Member

@marienfressinaud marienfressinaud commented Nov 1, 2024

In the feeds, the links to tags were in the form of /links?q=#tag. Most of the aggregators are able to rebuild the correct link by using the feed domain as the base URL. But it didn't work when the feeds were generated with the direct=true parameter because the base URL wasn't the one to Flus.

Now, the tags links are always generated in an absolute form to avoid this issue (even in the interface because it was easier to patch).

Pull request checklist:

  • code is manually tested
  • interface works on both mobiles and big screens
  • accessibility has been tested
  • tests are updated
  • French locale is synchronized
  • documentation is updated (including comments, commit messages, migration notes, …)

If you think one of the item isn’t applicable to the PR, please check it
anyway and precise N/A next to it.

In the feeds, the links to tags were in the form of `/links?q=#tag`.
Most of the aggregators are able to rebuild the correct link by using
the feed domain as the base URL. But it didn't work when the feeds were
generated with the `direct=true` parameter because the base URL wasn't
the one to Flus.

Now, the tags links are always generated in an absolute form to avoid
this issue (even in the interface because it was easier to patch).
@marienfressinaud marienfressinaud merged commit ccbcbbc into main Nov 1, 2024
4 checks passed
@marienfressinaud marienfressinaud deleted the fix/tags-links-in-feeds branch November 1, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant