Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imp: Allow to inherit Configuration to declare application types #79

Merged
merged 1 commit into from
Nov 29, 2024
Merged

imp: Allow to inherit Configuration to declare application types #79

merged 1 commit into from
Nov 29, 2024

Conversation

marienfressinaud
Copy link
Member

@marienfressinaud marienfressinaud commented Nov 29, 2024 •
edited
Loading

How to test manually

  1. Create a Minz app and setup PHPStan
  2. Declare a \App\Configuration class as described in the doc
  3. In the app, access an application option
  4. Verify that PHPStan doesn't complain about the type of the option

Reviewer checklist

  • Code is manually tested
  • Tests are up to date
  • Documentation is up to date
  • Pull request has been reviewed and approved

@marienfressinaud marienfressinaud force-pushed the imp/allow-inherit-configuration branch from 855b416 to 9c89a3e Compare November 29, 2024 10:08
@marienfressinaud marienfressinaud merged commit 9c89a3e into main Nov 29, 2024
2 checks passed
@marienfressinaud marienfressinaud deleted the imp/allow-inherit-configuration branch November 29, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marienfressinaud