Skip to content
This repository has been archived by the owner on Jun 13, 2024. It is now read-only.

Fix active tab color in Colors demo #1018

Merged
merged 8 commits into from
Oct 31, 2023
Merged

Fix active tab color in Colors demo #1018

merged 8 commits into from
Oct 31, 2023

Conversation

craiglabenz
Copy link
Contributor

Description

Screenshot 2023-10-02 at 1 59 22 PM

Fixes #1017

Tests

No tests - UI change only.

Issues

Fixes #

Note: Please find the development and releasing instructions at https://github.com/flutter/gallery#development

HansMuller
HansMuller reviewed Oct 2, 2023
View reviewed changes
Copy link
Contributor

@HansMuller HansMuller left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's definitely much better. Probably best to use the color scheme's onPrimary color.

FTR: the demo we'd like developers to see is /flutter/samples/tree/main/material_3_demo

guidezpl
guidezpl approved these changes Oct 3, 2023
View reviewed changes
lib/demos/reference/colors_demo.dart Outdated Show resolved Hide resolved
@domesticmouse domesticmouse added the autosubmit Merge PR when tree becomes green via auto submit App. label Oct 31, 2023
@auto-submit auto-submit bot merged commit 8b27795 into flutter:main Oct 31, 2023
11 checks passed
genx7up pushed a commit to aweps/gallery that referenced this pull request Dec 13, 2023
@craiglabenz @genx7up
Fix active tab color in Colors demo (flutter#1018)
5427e10 
## Description

<img width="440" alt="Screenshot 2023-10-02 at 1 59 22 PM" src="https://github.com/flutter/gallery/assets/855034/892d220e-fe1f-42a2-a49c-d35adab991fd">

Fixes flutter#1017 

## Tests

No tests - UI change only.

## Issues
Fixes #

---

>**Note**: Please find the development and releasing instructions at https://github.com/flutter/gallery#development
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@HansMuller HansMuller HansMuller left review comments

@guidezpl guidezpl guidezpl approved these changes

Assignees
No one assigned
Labels
autosubmit Merge PR when tree becomes green via auto submit App.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Colors demo has awkward active tab color
4 participants
@craiglabenz @HansMuller @guidezpl @domesticmouse