Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Runners, remove unused parameter #14

Merged
merged 8 commits into from
Dec 5, 2023
Merged

Update Runners, remove unused parameter #14

merged 8 commits into from
Dec 5, 2023

Conversation

domesticmouse
Copy link
Contributor

Pre-launch Checklist

  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I read the Contributors Guide.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-devrel channel on Discord.

@domesticmouse domesticmouse requested a review from filiph November 30, 2023 23:05
@domesticmouse
Copy link
Contributor Author

PTAL @spydon

filiph
filiph approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@filiph filiph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@domesticmouse domesticmouse merged commit b852eb9 into main Dec 5, 2023
7 checks passed
@domesticmouse domesticmouse deleted the fix-build branch December 5, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon left review comments

@filiph filiph filiph approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@domesticmouse @spydon @filiph