[various] Migrate example apps' AppDelegate.swift #8155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
p: palette_generator
p: pigeon
p: pointer_interceptor
p: flutter_markdown
p: flutter_image
p: rfw
loic-sharma
added
the
override: no versioning needed
|
test-exempt: boilerplate change in example apps |
loic-sharma
requested review from
cbracken,
hellohuanlin and
jmagman
as code owners
loic-sharma
requested review from
tarrinneal,
LouiseHsu,
domesticmouse,
bparrishMines,
Piinks,
Hixie,
ditman,
gspencergoog,
chunhtai and
goderbauer
as code owners
LouiseHsu
approved these changes
Nov 25, 2024
loic-sharma
added
override: no changelog needed
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption, contact "@test-exemption-reviewer" in the #hackers channel in Discord (don't just cc them here, they won't see it!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. The test exemption team is a small volunteer group, so all reviewers should feel empowered to ask for tests, without delegating that responsibility entirely to the test exemption group. |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 26, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 26, 2024
flutter/packages@46aeb2b...8ecf4b0 2024-11-26 stuartmorgan@google.com [file_selector] Update Pigeon version for Linux (flutter/packages#8172) 2024-11-25 737941+loic-sharma@users.noreply.github.com [various] Migrate example apps' AppDelegate.swift (flutter/packages#8155) 2024-11-25 737941+loic-sharma@users.noreply.github.com [various] Update example apps' .gitignore (flutter/packages#8156) 2024-11-25 49699333+dependabot[bot]@users.noreply.github.com [gradle]: Bump androidx.annotation:annotation from 1.9.0 to 1.9.1 in /packages/path_provider/path_provider_android/android (flutter/packages#8170) 2024-11-25 37843020+fransdhinta@users.noreply.github.com [vector_graphics_compiler] fix: handle parsing stroke-width with an invalid value (flutter/packages#8004) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-packages-flutter-autoroll Please CC flutter-ecosystem@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated by running:
Tests aren't updated as this change should not affect semantics. I will get a test exemption.
Part of flutter/flutter#159173
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or this PR is exempt from CHANGELOG changes.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.