ci: fix build ci to populate build-images.sh script #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The upstream "hack/build-images.sh" has had most variables for the environment removed in favor of an upstream Makefile, which we do not currently use in our custom build. Solution: define these variables in our Makefile equivalently. Signed-off-by: vsoch <vsoch@users.noreply.github.com>
vsoch
force-pushed
the
fix-build-args-needed
branch
from
b382f16 to
05e5a83
Compare
cmisale
approved these changes
Jul 31, 2024
|
Thank you @cmisale ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The upstream "hack/build-images.sh" has had most variables for the environment removed in favor of an upstream Makefile, which we do not currently use in our custom build.
Solution: define these variables in our Makefile equivalently.
Here is the changeset that resulted in our build error, merged 3 hours ago: kubernetes-sigs/scheduler-plugins@f07b943 and our failing build that detected the issue: https://github.com/flux-framework/flux-k8s/actions/runs/10127727592/job/28005857799