Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add disableSchemaValidation to Helm install/upgrade actions #1068

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

stefanprodan
Copy link
Member

This PR adds a new field called disableSchemaValidation to both .spec.install and .spec.upgrade that allows disabling the values validation against the JSON schema during install and upgrade.

Closes: fluxcd/flux2#4992

xref: helm/helm#12743

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan added the area/api API related issues and pull requests label Sep 20, 2024
Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stefanprodan stefanprodan merged commit 754c2ba into main Sep 24, 2024
7 checks passed
@stefanprodan stefanprodan deleted the disable-schema-validation branch September 24, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api API related issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

values.schema.json included in a helm chart leads to error in air-gapped environments (nginx-ingress)
2 participants