Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cross-shard dependency check #1070

Merged
merged 1 commit into from
Sep 26, 2024
Merged

Allow cross-shard dependency check #1070

merged 1 commit into from
Sep 26, 2024

Conversation

stefanprodan
Copy link
Member

@stefanprodan stefanprodan commented Sep 25, 2024

Use the APIReader client to bypass the controller runtime cache when checking for dependencies. This allows a HelmRelease to depend on other HelmReleases managed by different controller shards.

xref: fluxcd/kustomize-controller#1248

Copy link
Contributor

@darkowlzz darkowlzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
@stefanprodan stefanprodan merged commit b0010b0 into main Sep 26, 2024
6 checks passed
@stefanprodan stefanprodan deleted the deps-api-reader branch September 26, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants