Skip to content

Commit

Permalink
fix: Consistent artifact fetching retry timing
Browse files Browse the repository at this point in the history
Artifact not found errors (HTTP 404) are requeue using the dependency interval, while for a nil Artifact, the interval used for retry was set to the apply retry one.

Signed-off-by: Stefan Prodan <stefan.prodan@gmail.com>
(cherry picked from commit dff4c26)
  • Loading branch information
stefanprodan authored and github-actions[bot] committed Oct 4, 2023
1 parent d4fe928 commit 93f4b6b
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/controller/kustomization_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -244,10 +244,10 @@ func (r *KustomizationReconciler) Reconcile(ctx context.Context, req ctrl.Reques

// Requeue the reconciliation if the source artifact is not found.
if artifactSource.GetArtifact() == nil {
msg := "Source is not ready, artifact not found"
msg := fmt.Sprintf("Source artifact not found, retrying in %s", r.requeueDependency.String())
conditions.MarkFalse(obj, meta.ReadyCondition, kustomizev1.ArtifactFailedReason, msg)
log.Info(msg)
return ctrl.Result{RequeueAfter: obj.GetRetryInterval()}, nil
return ctrl.Result{RequeueAfter: r.requeueDependency}, nil
}

// Check dependencies and requeue the reconciliation if the check fails.
Expand Down

0 comments on commit 93f4b6b

Please sign in to comment.