Make staticcheck happy

flyingmutant · Nov 17, 2022 · fc2893c · fc2893c
1 parent dbb2839
commit fc2893c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/global_test.go b/global_test.go
@@ -111,7 +111,7 @@ func TestUint32n(t *testing.T) {
 	rapid.Check(t, func(t *rapid.T) {
 		n := rapid.Uint32Range(1, math.MaxUint32).Draw(t, "n").(uint32)
 		v := rand.Uint32n(n)
-		if v < 0 || v >= n {
+		if v >= n {
 			t.Fatalf("got %v outside of [0, %v)", v, n)
 		}
 	})
@@ -121,7 +121,7 @@ func TestUint64n(t *testing.T) {
 	rapid.Check(t, func(t *rapid.T) {
 		n := rapid.Uint64Range(1, math.MaxUint64).Draw(t, "n").(uint64)
 		v := rand.Uint64n(n)
-		if v < 0 || v >= n {
+		if v >= n {
 			t.Fatalf("got %v outside of [0, %v)", v, n)
 		}
 	})

diff --git a/rand_test.go b/rand_test.go
@@ -99,7 +99,7 @@ func TestRand_Uint32n(t *testing.T) {
 		r := rand.New(s)
 		n := rapid.Uint32Range(1, math.MaxUint32).Draw(t, "n").(uint32)
 		v := r.Uint32n(n)
-		if v < 0 || v >= n {
+		if v >= n {
 			t.Fatalf("got %v outside of [0, %v)", v, n)
 		}
 	})
@@ -111,7 +111,7 @@ func TestRand_Uint64n(t *testing.T) {
 		r := rand.New(s)
 		n := rapid.Uint64Range(1, math.MaxUint64).Draw(t, "n").(uint64)
 		v := r.Uint64n(n)
-		if v < 0 || v >= n {
+		if v >= n {
 			t.Fatalf("got %v outside of [0, %v)", v, n)
 		}
 	})

diff --git a/std_rand_test.go b/std_rand_test.go
@@ -55,14 +55,14 @@ var testSeeds = []int64{1, 1754801282, 1698661970, 1550503961}
 
 // checkSimilarDistribution returns success if the mean and stddev of the
 // two statsResults are similar.
-func (this *statsResults) checkSimilarDistribution(expected *statsResults) error {
-	if !nearEqual(this.mean, expected.mean, expected.closeEnough, expected.maxError) {
-		s := fmt.Sprintf("mean %v != %v (allowed error %v, %v)", this.mean, expected.mean, expected.closeEnough, expected.maxError)
+func (sr *statsResults) checkSimilarDistribution(expected *statsResults) error {
+	if !nearEqual(sr.mean, expected.mean, expected.closeEnough, expected.maxError) {
+		s := fmt.Sprintf("mean %v != %v (allowed error %v, %v)", sr.mean, expected.mean, expected.closeEnough, expected.maxError)
 		fmt.Println(s)
 		return errors.New(s)
 	}
-	if !nearEqual(this.stddev, expected.stddev, expected.closeEnough, expected.maxError) {
-		s := fmt.Sprintf("stddev %v != %v (allowed error %v, %v)", this.stddev, expected.stddev, expected.closeEnough, expected.maxError)
+	if !nearEqual(sr.stddev, expected.stddev, expected.closeEnough, expected.maxError) {
+		s := fmt.Sprintf("stddev %v != %v (allowed error %v, %v)", sr.stddev, expected.stddev, expected.closeEnough, expected.maxError)
 		fmt.Println(s)
 		return errors.New(s)
 	}