Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Use configured domain on expired cookies #608

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Use configured domain on expired cookies #608

merged 4 commits into from
Sep 1, 2023

Conversation

iaroslav-ciupin
Copy link
Contributor

TL;DR

When expiring cookie during logout, we must use same configured domain as when setting those cookies.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +1.68% 🎉

Comparison is base (1df2d18) 58.74% compared to head (397b8d5) 60.43%.

❗ Current head 397b8d5 differs from pull request most recent head eda6193. Consider uploading reports for the commit eda6193 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   58.74%   60.43%   +1.68%     
==========================================
  Files         171      171              
  Lines       16472    13442    -3030     
==========================================
- Hits         9676     8123    -1553     
+ Misses       5944     4471    -1473     
+ Partials      852      848       -4     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
auth/handlers.go 35.79% <ø> (-0.54%) ⬇️
auth/cookie.go 81.60% <100.00%> (+12.51%) ⬆️
auth/cookie_manager.go 63.71% <100.00%> (+10.04%) ⬆️

... and 155 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@katrogan katrogan merged commit 6f49854 into master Sep 1, 2023
14 checks passed
@katrogan katrogan deleted the logout-cookies branch September 1, 2023 16:05
eapolinario pushed a commit that referenced this pull request Sep 6, 2023
* use configured domain on expired cookies

Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>

* unit tests coverage

Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>

---------

Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants