Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Logout hook plugin #611

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Logout hook plugin #611

merged 5 commits into from
Sep 12, 2023

Conversation

iaroslav-ciupin
Copy link
Contributor

TL;DR

This hook allows to execute code before running actual logout handler

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Patch coverage: 84.61% and project coverage change: +1.56% 🎉

Comparison is base (b32a3d3) 58.93% compared to head (7290799) 60.50%.

❗ Current head 7290799 differs from pull request most recent head a254eda. Consider uploading reports for the commit a254eda to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   58.93%   60.50%   +1.56%     
==========================================
  Files         171      171              
  Lines       16460    13442    -3018     
==========================================
- Hits         9701     8133    -1568     
+ Misses       5909     4458    -1451     
- Partials      850      851       +1     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
plugins/registry.go 100.00% <ø> (ø)
auth/handlers.go 40.15% <83.33%> (+3.81%) ⬆️
auth/cookie.go 81.60% <100.00%> (+2.76%) ⬆️

... and 155 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

katrogan
katrogan previously approved these changes Sep 7, 2023
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
katrogan
katrogan previously approved these changes Sep 11, 2023
Signed-off-by: Iaroslav Ciupin <iaroslav@union.ai>
@iaroslav-ciupin iaroslav-ciupin merged commit df88d23 into master Sep 12, 2023
14 checks passed
@iaroslav-ciupin iaroslav-ciupin deleted the logout-hook branch September 12, 2023 18:17
eapolinario pushed a commit that referenced this pull request Sep 28, 2023
* logout hook plugin
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants