Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add Trigger support to UI #860

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Conversation

jsonporter
Copy link
Contributor

This PR adds support for triggers (previously schedules) in the new flyteConsole refresh. Users can now view, activate and deactivate schedules from the UI. Additionally, users can activate/deactivate launch plans even if there is no schedule bound to the launch plan. Finally, this PR includes a performance update (virtualized) to the Launch Plan search UI making string searches much more performant.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

Remove the 'fixes' keyword if there will be multiple PRs to fix the linked issue

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA
OR
https://github.com/flyteorg/flyte/issues/

Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Jason Porter <jason@union.ai>
Signed-off-by: Jason Porter <jason@union.ai>
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 33.20053% with 503 lines in your changes are missing coverage. Please review.

Project coverage is 54.76%. Comparing base (3920ce8) to head (2bda2b3).

Files Patch % Lines
...ents/LaunchPlan/components/ChangeScheduleModal.tsx 27.08% 70 Missing ⚠️
...e/src/components/Entities/EntitySchedulesCells.tsx 31.81% 60 Missing ⚠️
...mponents/LaunchPlan/components/LaunchPlanCells.tsx 32.35% 46 Missing ⚠️
...onents/LaunchPlanScheduleContextMenuFromNameId.tsx 26.66% 44 Missing ⚠️
...hPlan/components/LaunchPlanScheduleContextMenu.tsx 31.37% 35 Missing ⚠️
...mponents/LaunchPlan/components/ScheduleDetails.tsx 39.39% 20 Missing ⚠️
...LaunchPlan/components/LaunchPlanVersionDetails.tsx 29.16% 17 Missing ⚠️
.../LaunchPlan/hooks/useLatestScheduledLaunchPlans.ts 29.16% 17 Missing ⚠️
.../LaunchPlan/components/DeactivateScheduleModal.tsx 42.85% 16 Missing ⚠️
...onsole/src/components/Entities/EntitySchedules.tsx 37.50% 15 Missing ⚠️
... and 21 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #860      +/-   ##
==========================================
- Coverage   55.30%   54.76%   -0.54%     
==========================================
  Files         564      578      +14     
  Lines       14620    15137     +517     
  Branches     2668     2760      +92     
==========================================
+ Hits         8085     8290     +205     
- Misses       6535     6847     +312     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsonporter jsonporter merged commit 7aabb32 into master Apr 2, 2024
10 of 12 checks passed
@jsonporter jsonporter deleted the json/fork-patch-schedules branch April 2, 2024 17:05
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants