Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Dockerfile smell DL3008 #122

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grosa1
Copy link

@grosa1 grosa1 commented Apr 12, 2023

Hi!
The Dockerfile placed at "Dockerfile" contains the best practice violation DL3008 detected by the hadolint tool.

The smell DL3008 occurs when the version pinning for the installed packages with apt is not specified. This could lead to unexpected behavior when building the Dockerfile.
In this pull request, we propose a fix for that smell generated by our fixing tool. We have verified that the patch is correct before opening the pull request.
To fix this smell, specifically, we use a heuristic approach that selects the most probable version tag for a given apt package corresponding to the latest version at the current date. The package versions are retrieved from the Canonical Launchpad APIs.

This change is only aimed at fixing that specific smell. If the fix is not valid or useful, please briefly indicate the reason and suggestions for possible improvements.

Thanks in advance

Signed-off-by: Giovanni Rosa <g.rosa1@studenti.unimol.it>
@Barry-RG
Copy link
Contributor

Barry-RG commented Apr 18, 2023

Thank you for your PR, it will be reviewed shortly.
We are currently updating our dockerfile so this will become part of that review process.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants