Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a colon to the end of the target session when creating windows #38

Merged
merged 2 commits into from
Jan 29, 2024

Conversation

fmauch
Copy link
Owner

@fmauch fmauch commented Jan 28, 2024

Otherwise the target might get interpreted wrong resulting in the window not being created.

Fixes #37

Otherwise the target might get interpreted wrong resulting in the window not being created.
Copy link

codecov bot commented Jan 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f8b837f) 100.00% compared to head (a261343) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #38   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          214       214           
=========================================
  Hits           214       214           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fmauch fmauch marked this pull request as ready for review January 28, 2024 20:10
@fmauch fmauch merged commit 21a9eb7 into master Jan 29, 2024
11 checks passed
@fmauch fmauch deleted the fix_session_is_substr_of_window branch January 29, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using a session name that is a prefix of the first window results in missing windows
1 participant