Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various code style issues #165

Merged
merged 9 commits into from
Jul 30, 2024
Merged

Fix various code style issues #165

merged 9 commits into from
Jul 30, 2024

Commits on Jul 29, 2024

  1. Fix various code style issues

    Most importantly, don't use module names that are the same as the contained class names,
    as this can lead to errors where the import order matters, as classes are confused with their modules.
    (For example, this was the case if you sorted imports of hcs/imagexpress/__init__.py before this commit.)
    
    We now collect several classes into single (sub-)modules.
    
    Usages of `xml`/`lxml` where replaced by alternatives from `defusedxml`.
    
    This commit also fixes various other errors reported by `hatch fmt` (i.e. ruff).
    imagejan committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    df72644 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a8ade9e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6ca845b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f3c4529 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0de5360 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    17f87d4 View commit details
    Browse the repository at this point in the history
  7. Sort pyproject.toml

    Achieved by:
    
        toml-sort --trailing-comma-inline-array -o pyproject.toml .\pyproject.toml
    
    (also sort dependencies)
    imagejan committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    1016841 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Use lowercase function names everywhere

    (also in tests)
    imagejan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    2e089f6 View commit details
    Browse the repository at this point in the history
  2. hcs.plate: make more concise

    imagejan committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    d008b11 View commit details
    Browse the repository at this point in the history