Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make date optional when parsing imagexpress data #195

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Make date optional when parsing imagexpress data #195

merged 1 commit into from
Nov 14, 2024

Conversation

fstur
Copy link
Collaborator

@fstur fstur commented Nov 13, 2024

When exporting data from the MD imagexpress at the ZMB, we usually don't have a folder with the date. Could we make the date optional when parsing the data?

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.80%. Comparing base (ca2c7ac) to head (c79f7a0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #195   +/-   ##
=======================================
  Coverage   92.80%   92.80%           
=======================================
  Files          64       64           
  Lines        3918     3918           
  Branches      245      245           
=======================================
  Hits         3636     3636           
  Misses        268      268           
  Partials       14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fstur
Copy link
Collaborator Author

fstur commented Nov 13, 2024

Hi @imagejan and @tibuch,
Could we slightly adjust the regex patterns when parsing imagexpress data to make the date optional?
I could also add a small ZMB-dataset & some adjusted tests if that's ok with you.

@imagejan
Copy link
Member

Thanks @fstur for the suggestion. It's true that we don't make use of the date column in the resulting _files dataframe in our conversion code.
Is your system producing a folder structure lacking the date, or are these changes to the directory structure introduced later (e.g. by copying only a subset/subfolder)?

I'll merge this to accommodate your use case, please feel free to also set up a test if you have datasets that significantly differ from what we already have.

@imagejan imagejan merged commit 02a43e9 into main Nov 14, 2024
12 checks passed
@imagejan imagejan deleted the zmb branch November 14, 2024 11:12
@fstur
Copy link
Collaborator Author

fstur commented Nov 14, 2024

Thanks @imagejan for merging.
In our system, no date is saved in the folder structure. Where in your case is the date, we have an arbitrary folder-name that is provided by the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants