Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StationsWorkedBefore #478

Closed
wants to merge 2 commits into from
Closed

StationsWorkedBefore #478

wants to merge 2 commits into from

Conversation

aa5sh
Copy link

@aa5sh aa5sh commented Oct 8, 2024

Added another Grid for callsign statistics. Issue #477

image

Added another Grid for callsign statistics.
@foldynl
Copy link
Owner

foldynl commented Nov 5, 2024

I have a question. Why did you use like in this c.callsign like '%3'.

Shouldn't it rather use callsign == '%3' ? And that's more of a question about what this widget is supposed to display. Do I want to see statistics for a specific station or for the base callsign? There's a difference if I generate statistics for SP/OK1MLG or just for OK1MLG. In my opinion, it should use callsign == '%3' because I would like to recognize the cases when QSO is with SP/OK1MLG or only with OK1MLG. What do you think about this ?

@aa5sh
Copy link
Author

aa5sh commented Nov 5, 2024 via email

@foldynl
Copy link
Owner

foldynl commented Nov 24, 2024

It is a part of 0.40. Thank you

@foldynl foldynl closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done - branch: testing_0.40
Development

Successfully merging this pull request may close these issues.

2 participants