Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds station county and operator callsign to the station and deps #497

Closed
wants to merge 1 commit into from

Conversation

kyleboyle
Copy link

@kyleboyle kyleboyle commented Nov 9, 2024

Adds operator (callsign) (fixes #441) and my_cnty (station county) (fixes #493) to station info.

station config:
Screenshot 2024-11-08 at 8 55 03 PM

Explicit "different operator than station" status:
Screenshot 2024-11-08 at 8 54 45 PM

QSO fields, moved shack info to 3rd column:
Screenshot 2024-11-08 at 8 54 37 PM

@foldynl If there are other changes necessary as far as station_callsign VERSUS operator (you mentioned "changing the logic in TSQL and other exports.") please let me know what needs to be updated. ADIF fields my_cnty and operator are exported correctly.

@foldynl
Copy link
Owner

foldynl commented Nov 10, 2024

Many thanks.

I just reviewed it quickly, and it looks good. The issue with macOS isn't related to your changes.

Yes, I mentioned the TQSL and eQSL export, but the export was enhanced with a custom filter, which could potentially solve the issue. We'll wait to see the user's reaction.

@kyleboyle
Copy link
Author

Sounds good... just curious about your concerns with the external service uploads -- I presume it has to do with what QSOs to associate with the external service account?

I opted to not implement the 'station owner' field... as it is not useful for anything IMO.

@foldynl
Copy link
Owner

foldynl commented Nov 11, 2024

I presume it has to do with what QSOs to associate with the external service account?

Yes, exactly. I have no previous experience with the "Operator Callsign" operation, that's why I'm worried about it, because I don't know how in such a case operators have to set the external services. Currently, the custom filter is present only in the ADIF export. If required, it will be extended to other parts. Unfortunately, the unified Upload/Download feature will not be included in the upcoming version (0.40). I’m having trouble debugging the new features, and adding this would cause a significant delay for the entire release.

I opted to not implement the 'station owner' field... as it is not useful for anything IMO.

Perfect, no problem. I would like to have QLog with a minimal number of settings.

@foldynl
Copy link
Owner

foldynl commented Nov 14, 2024

in the next few days I will release Testing 0.40. I don't know how you developed QLog, but we had a conflict in the SQL script. This is not a problem, but you will have to manually patch the database before starting Testing 0.40. The following SQLs will be needed.

CREATE TABLE IF NOT EXISTS activity_profiles(
        profile_name TEXT PRIMARY KEY,
        config TEXT,
        selected INTEGER
);

INSERT INTO activity_profiles
SELECT profile_name, json_object(
           'activityName', profile_name,
           'profiles', json_array(
               json_object(
                   'profileType', 4,
                   'name', profile_name
               )
           )
       ) AS config,
       selected
FROM main_layout_profiles;


ALTER TABLE alert_rules ADD COLUMN ituz INTEGER;
ALTER TABLE alert_rules ADD COLUMN cqz INTEGER;

ALTER TABLE main_layout_profiles ADD tabsexpanded INTEGER DEFAULT 1;

It is possible that you remove the database before each test, then you do not have to do this, because it is done automatically.

@aa5sh
Copy link

aa5sh commented Nov 17, 2024

It would be nice to have the Counties prefill in the proper format like POTA, WWFF, IOTA etc. It could be used both here and in the QSO for the other stations County.

@aa5sh
Copy link

aa5sh commented Nov 18, 2024

@foldynl
Copy link
Owner

foldynl commented Nov 24, 2024

It is a part of 0.40. Thank you

@foldynl foldynl closed this Nov 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Station Profile - County Owner Callsign, Station Callsign, Operator
3 participants