Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mod-data-export-worker 4.0.0 upgrades
* Refine fetching to allow filtering on: fee type - closes #16 * compared UUIDs instead of strings * Update submodule * update submodule (again) * Add location ID filter (closes #19) * Add location ID filter (closes #19) (#55) * Fetch all ancillary data (close #48) * Create filter and job config context architecture * Add location ID filter (closes #19) * Remove unnecessary import and code * Add support for conditional constant token * Clean up unnecessary imports * Add support for constant conditional token and clean up imports * Add service point ID filter * add supoort for item metadata data token - closes #33 * allow filtering on fine amount - closes #14 * Update submodule * Fix typo * Changes to aggregate token * Update submodule * Update submodule * update submodule * Fix aggregate amounts * Update submodule * Add pass filter * Assorted token formatter improvements * Update submodule * Create new class to store aggregated data by user * Properly handle optional user and item data (closes #33, closes #36) * Fix submodule reversion * Properly handle optional user and item data (closes #33, closes #36) (#69) * Fetch all ancillary data (close #48) * Create filter and job config context architecture * Add location ID filter (closes #19) * Properly handle optional user and item data (closes #33, closes #36) * Fix submodule reversion * get filtered accounts in TransferFeesFinesTasklet - closes #68 * Fix typo * Prevent empty user/item queries * Add support for FeeDate data token * Updated submodule folio-export-common * Update submodule * Add aggregating accounts implemetation in reader * update folio-export-common * implement transfer fee/fines functionality - closes #8 * Create new reader for the aggregated accounts and clean up old reader * Create new filter evaluator for aggregate accounts * update to FEC * update to fec * check size of accountsToBeTransferred List for each filter condition before creating transfer request * Updated submodule folio-export-common * Clean up imports * Implement aggregated account filterer * Delete to reset commit * Create new filter evaluator for aggregate accounts * Add log error to invalid case condition * Use int instead for comparing values * Add support for formatting aggregated accounts by users * Add findTotalAmount() method to AggregatedAccounts class * Change the user formatting methods' parameter to reuse it for aggregate * Change to use findTotalAmount() method instead * Delete comment * Fix bugs for aggregate reader, formatter, and filter evaluator * Implement conditional flow for aggregate by patron job * Add check for groupByPatron for conditional flow * Update src/main/java/org/folio/dew/batch/bursarfeesfines/BursarExportJobConfig.java Co-authored-by: Noah Overcash <ncovercash@ua.edu> * Clean up code * Remove redundant call to .user() * Add transfer aggregated accounts * closes #81 * pull from folio-export-common * update folio-export-common * Add support for new data token - Conditional - #81 (#83) * closes #81 * pull from folio-export-common * update folio-export-common * added support for BursarExportFilterFeeFineOwner * closes #86 * closes #86 * fixed formatting * removed support for CORNELL_EXTERNAL_SYSTEM_ID option in UserData data token * closes #101 * Add jacoco * Use hamcrest * resolve issues * Changes to help with testing * Closes #100 * Closes #104 * resolve issues * Fix bad jacoco configuration * Fix tests * resolve issues * Cleanup bursar export service * More coverage for BursarFilterAggregateEvaluatorTest * Add testing aggregateEvaluate with inapplicable filter * Unit test for BursarExportUtils * Modify and write unit test for AggregatedAccountReader * added barebones for integration testing * closes #105 * Update sonar * Correct java version * Correct java distribution * Correct sonar key * Test without actions? * Test inconsequential sonar * Revert "Test without actions?" This reverts commit 869c2ad. * Update submodule * Fix merge error * skip bad tests * Add sonar URL * Try only one test for speed * bruh * Restore all sonar tests * Update checkout depth for sonar recency * no clue how i did that... * Move bursar integration tests into separate folder (#126) * Update submodule * Move no fees fines test * Remove temporary test code in AccountReader * resolve issues with original pull request :#122 --------- Co-authored-by: GoZaddy <faruqyusuff437@gmail.com> * Modify and write unit test for BursarTokenFormatter * Clean up unnecessary logs * Remove log import * Write unit test for BursarTokenFormatter - closes #102 (#127) * Modify and write unit test for BursarTokenFormatter * Clean up unnecessary logs * Remove log import * Create an integration test for: one fee/fine criteria - #107 (#128) * Update submodule * Move no fees fines test * Remove temporary test code in AccountReader * resolve issues with original pull request :#122 * closes #107 * fixed issues in PR * fixed formatting * check that filesInStorage is not null * updates --------- Co-authored-by: Noah Overcash <novercash@ebsco.com> * Clean up code smells * Change log errors to be more specific * Make number 7 into a constant * Clean up import * Clean up code smells (#129) * Modify and write unit test for BursarTokenFormatter * Clean up unnecessary logs * Remove log import * Clean up code smells * Change log errors to be more specific * Make number 7 into a constant * Clean up import * Create integration test for no fee fine matching criteria * Add expected output * Create integration test for no fee fine matching criteria (#131) * Modify and write unit test for BursarTokenFormatter * Clean up unnecessary logs * Remove log import * Clean up code smells * Change log errors to be more specific * Make number 7 into a constant * Clean up import * Create integration test for no fee fine matching criteria * Add expected output * Create integration test for multiple matching fees * Create integration test for multiple fees matching criteria (#132) * Remove non-ISO week year date format options * Add checks for null/optional account dates * Create integration test that uses most output tokens * Clean up unit tests * Create integration test that uses most output tokens (#133) * Modify and write unit test for BursarTokenFormatter * Clean up unnecessary logs * Remove log import * Clean up code smells * Change log errors to be more specific * Make number 7 into a constant * Clean up import * Create integration test for no fee fine matching criteria * Add expected output * Create integration test for multiple matching fees * Create integration test that uses most output tokens * Clean up unit tests * Clean up code * Create integration test for fees/fines matching initial criteria but not aggregate criteria * Clean up imports * Correct mocked request content * Create integration test for fee/fines that match initial criteria but not aggregate criteria (#135) * Modify and write unit test for BursarTokenFormatter * Clean up unnecessary logs * Remove log import * Clean up code smells * Change log errors to be more specific * Make number 7 into a constant * Clean up import * Create integration test for no fee fine matching criteria * Add expected output * Create integration test for multiple matching fees * Create integration test that uses most output tokens * Clean up unit tests * Clean up code * Create integration test for fees/fines matching initial criteria but not aggregate criteria * Clean up imports * Correct mocked request content * Closes #112, #114 * Remove temporary GA * Fix mismatch file * Fix: add new line to data token of MultipleFeeFinesAcrossPatronsAggregateTest * Update submodule * Add draft of new test * Create test for BursarExportService * Fix modifier * Create test for BursarExportService (#137) * Add draft of new test * Create test for BursarExportService * Fix modifier * Fix assorted unsafe null checks to Item * Modify and complete BursarExportService test * Clean up and add necessary imports * Cleanup * Add test for getAllAccounts() and refactor other tests * Finish integration test for BursarExportService (#138) * Modify and complete BursarExportService test * Clean up and add necessary imports * Cleanup * Add test for getAllAccounts() and refactor other tests --------- Co-authored-by: Noah Overcash <novercash@ebsco.com> * Add descriptive failure error messages (closes #139) (#140) * Add descriptive failure error messages (closes #139) * Change exception handling * Change assertion method * Update module descriptor * Update version in pom.xml * Update module descriptor * Revert changes * Update module descriptor (#141) * Modify and complete BursarExportService test * Clean up and add necessary imports * Cleanup * Add test for getAllAccounts() and refactor other tests * Update module descriptor * Update version in pom.xml * Update module descriptor * Revert changes --------- Co-authored-by: Noah Overcash <novercash@ebsco.com> * Updated submodule folio-export-common * Updated submodule folio-export-common * Updated submodule folio-export-common * Updated submodule folio-export-common * Correct UserData types and add date options * Added tests for processDateToken new options (#145) * Remove test log * Fix code smell * Add coverage to modified code * Add date formatting options (and correct userData types) (#144) * Modify and complete BursarExportService test * Clean up and add necessary imports * Cleanup * Add test for getAllAccounts() and refactor other tests * Update module descriptor * Update version in pom.xml * Update module descriptor * Revert changes * Updated submodule folio-export-common * Updated submodule folio-export-common * Correct UserData types and add date options * Added tests for processDateToken new options (#145) * Remove test log * Fix code smell * Add coverage to modified code --------- Co-authored-by: Noah Overcash <novercash@ebsco.com> Co-authored-by: Dane Tsao <danetsaoo@gmail.com> * Updated submodule folio-export-common * Updated submodule folio-export-common * Add conditions to filter age (#147) * Add condition for age filter and additional tests * Remove unnecessary log * fix bug: issue #148 (#149) * fix bug: issue #148 * fix bug: issue #148 --------- Co-authored-by: Noah Overcash <ncovercash@ua.edu> Co-authored-by: GoZaddy <faruqyusuff437@gmail.com> Co-authored-by: Noah Overcash <novercash@ebsco.com> Co-authored-by: Dane Tsao <danetsaoo@gmail.com>
- Loading branch information
5 people
authored
Sep 26, 2023
1 parent
6bcc1a4
commit 3891ce7