[MODEXPW-528] Generate EDI file for claims #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azizbekxm
reviewed
Dec 6, 2024
Comment on lines
99
to
110
| private String fieldInListFilter(String fieldName, List<?> list) { | ||
| return String.format(" AND %s==%s", fieldName, | ||
| list.stream() | ||
| .map(item -> String.format("\"%s\"", item.toString())) | ||
| .collect(Collectors.joining(" OR ", "(", ")"))); | ||
| } | ||
|
|
||
| private static String fieldNotInListFilter(String fieldName, Collection<?> list) { | ||
| return String.format(" AND cql.allRecords=1 NOT %s==%s", fieldName, | ||
| list.stream() | ||
| .map(item -> String.format("\"%s\"", item.toString())) | ||
| .collect(Collectors.joining(" OR ", "(", ")"))); |
There was a problem hiding this comment.
There was a problem hiding this comment.
Reused existing util methods instead of these, both are removed
|
Looks good to me, but is that NOSONAR tag really needed? |
BKadirkhodjaev
approved these changes
Dec 9, 2024
Yes I remember sonar was alarming about some security issue with the regex provided in this mod-orders PR |
SerhiiNosko
reviewed
Dec 9, 2024
SerhiiNosko
reviewed
Dec 9, 2024
...main/java/org/folio/dew/batch/acquisitions/edifact/exceptions/EntitiesNotFoundException.java
Outdated
Show resolved
Hide resolved
SerhiiNosko
reviewed
Dec 9, 2024
SerhiiNosko
reviewed
Dec 9, 2024
src/main/java/org/folio/dew/batch/acquisitions/edifact/jobs/EdifactExportJobConfig.java
Show resolved
Hide resolved
SerhiiNosko
approved these changes
Dec 9, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
[MODEXPW-528] Generate EDI file for claims
Approach
Learning
When writing special characters -
.,?,:,'they will always be escaped with?. So if we writeabc?12:3the output will beabc??12?:3.To avoid this we need to user binary writer instead of string:
.writeStartElementBinary().writeBinaryData(ByteBuffer.wrap(data.getBytes()))