-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MODFIN-379] - Create API for retrieve finance data #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azizbekxm
changed the title
[MODFIN-379] - Create API for fund updates logs
[MODFIN-379] - Create API for retrieve finance data
Nov 19, 2024
This was referenced Nov 20, 2024
SerhiiNosko
reviewed
Nov 20, 2024
@@ -64,6 +68,11 @@ public void initMocks() { | |||
requestContext = new RequestContext(context, okapiHeaders); | |||
} | |||
|
|||
@AfterEach | |||
void clearContext() throws Exception { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good approach, we should use this in every new test that opens mocks
BKadirkhodjaev
approved these changes
Nov 20, 2024
Saba-Zedginidze-EPAM
approved these changes
Nov 20, 2024
SerhiiNosko
approved these changes
Nov 20, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
https://folio-org.atlassian.net/browse/MODFIN-388
Approach
Related prs
folio-org/acq-models#488
folio-org/mod-finance-storage#433