Spitfire minor fixes

folio-org · Jan 8, 2025 · 81d00f5 · 81d00f5
1 parent 66bf0c3
commit 81d00f5
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 7 deletions.
diff --git a/cypress/e2e/consortia/settings/marc-authority/view-authority-files-central-member.cy.js b/cypress/e2e/consortia/settings/marc-authority/view-authority-files-central-member.cy.js
@@ -77,7 +77,7 @@ describe('MARC', () => {
               ManageAuthorityFiles.checkAuthorityFilesTableExists();
               ManageAuthorityFiles.verifyTableHeaders();
               ManageAuthorityFiles.checkActiveTooltipButtonShown();
-              ManageAuthorityFiles.checkNewButtonEnabled(false);
+              ManageAuthorityFiles.checkNewButtonShown(false);
               ManageAuthorityFiles.checkManageAuthorityFilesPaneExists();
               ManageAuthorityFiles.checkAuthorityFilesTableNotEditable();
 
@@ -87,7 +87,7 @@ describe('MARC', () => {
               ManageAuthorityFiles.checkAuthorityFilesTableExists();
               ManageAuthorityFiles.verifyTableHeaders();
               ManageAuthorityFiles.checkActiveTooltipButtonShown();
-              ManageAuthorityFiles.checkNewButtonEnabled(false);
+              ManageAuthorityFiles.checkNewButtonShown(false);
               ManageAuthorityFiles.checkManageAuthorityFilesPaneExists();
               ManageAuthorityFiles.checkAuthorityFilesTableNotEditable();
             });
@@ -107,7 +107,7 @@ describe('MARC', () => {
               ManageAuthorityFiles.checkAuthorityFilesTableExists();
               ManageAuthorityFiles.verifyTableHeaders();
               ManageAuthorityFiles.checkActiveTooltipButtonShown();
-              ManageAuthorityFiles.checkNewButtonEnabled(false);
+              ManageAuthorityFiles.checkNewButtonShown(false);
               ManageAuthorityFiles.checkManageAuthorityFilesPaneExists();
               ManageAuthorityFiles.checkAuthorityFilesTableNotEditable();
 

diff --git a/cypress/support/api/inventory.js b/cypress/support/api/inventory.js
@@ -13,7 +13,7 @@ const DEFAULT_INSTANCE = {
 const displaySettingsBody = {
   id: uuid(),
   key: 'display-settings',
-  scope: 'ui-inventory.display-settings',
+  scope: 'ui-inventory.display-settings.manage',
   value: {
     defaultSort: '',
   },
@@ -544,7 +544,7 @@ Cypress.Commands.add('getInventoryDisplaySettingsViaAPI', () => {
       method: 'GET',
       path: 'settings/entries',
       searchParams: {
-        query: '(scope==ui-inventory.display-settings and key==display-settings)',
+        query: '(scope==ui-inventory.display-settings.manage and key==display-settings)',
       },
       isDefaultSearchParamsRequired: false,
     })

diff --git a/cypress/support/fragments/settings/marc-authority/manageAuthorityFiles.js b/cypress/support/fragments/settings/marc-authority/manageAuthorityFiles.js
@@ -545,11 +545,16 @@ export default {
   },
 
   waitContentLoading() {
-    cy.expect([firstRow.exists(), newButton.has({ disabled: or(true, false) })]);
+    cy.expect(firstRow.exists());
     cy.wait(3000);
   },
 
   checkActiveTooltipButtonShown() {
     cy.expect(MultiColumnListHeader(tableHeaderTexts[4]).find(tooltipButton).exists());
   },
+
+  checkNewButtonShown(isShown = true) {
+    if (isShown) cy.expect(newButton.exists());
+    else cy.expect(newButton.absent());
+  },
 };
diff --git a/cypress/support/login.js b/cypress/support/login.js
@@ -41,7 +41,7 @@ Cypress.Commands.add(
 Cypress.Commands.add('logout', () => {
   cy.do([Dropdown({ id: 'profileDropdown' }).open(), Button('Log out').click()]);
 
-  cy.expect(Button('Log in', { disabled: true }).exists());
+  cy.expect(Button('Log in again', { disabled: true }).exists());
 });
 
 Cypress.Commands.add('loginAsAdmin', (visitPath) => {