Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: UIREC-393 invalid reference issues due to BE resolving the invalid holding/locations data #611

Merged
merged 2 commits into from
Nov 21, 2024

Conversation

alisher-epam
Copy link
Contributor

Purpose

Revert: UIREC-393 invalid reference issues due to BE resolving the invalid holding/locations data

Approach

Screenshots

1120.mp4

Pre-Merge Checklist

Before merging this PR, please go through the following list and take appropriate actions.

  • I've added appropriate record to the CHANGELOG.md
  • Does this PR meet or exceed the expected quality standards?
    • Code coverage on new code is 80% or greater
    • Duplications on new code is 3% or less
    • There are no major code smells or security issues
  • Does this introduce breaking changes?
    • If any API-related changes - okapi interfaces and permissions are reviewed/changed correspondingly
    • There are no breaking changes in this PR.

If there are breaking changes, please STOP and consider the following:

  • What other modules will these changes impact?
  • Do JIRAs exist to update the impacted modules?
    • If not, please create them
    • Do they contain the appropriate level of detail? Which endpoints/schemas changed, etc.
    • Do they have all they appropriate links to blocked/related issues?
  • Are the JIRAs under active development?
    • If not, contact the project's PO and make sure they're aware of the urgency.
  • Do PRs exist for these changes?
    • If so, have they been approved?

Ideally all of the PRs involved in breaking changes would be merged in the same day to avoid breaking the folio-testing environment. Communication is paramount if that is to be achieved, especially as the number of intermodule and inter-team dependencies increase.

While it's helpful for reviewers to help identify potential problems, ensuring that it's safe to merge is ultimately the responsibility of the PR assignee.

@alisher-epam alisher-epam self-assigned this Nov 20, 2024
@alisher-epam alisher-epam requested review from usavkov-epam and a team November 20, 2024 14:48

This comment has been minimized.

Copy link

Jest Unit Test Statistics

287 tests   - 1   285 ✔️  - 1   3m 18s ⏱️ -4s
  96 suites ±0       2 💤 ±0 
    1 files   ±0       0 ±0 

Results for commit 30aa625. ± Comparison against base commit 805be2d.

This pull request removes 2 and adds 1 tests. Note that renamed tests count towards both.
useHoldingsAndLocations should fetch holding locations with different tenants ‑ useHoldingsAndLocations should fetch holding locations with different tenants
useHoldingsAndLocations should fetch holding locations ‑ useHoldingsAndLocations should fetch holding locations
useHoldingsAndLocations should fetch pieces requests ‑ useHoldingsAndLocations should fetch pieces requests

Copy link

github-actions bot commented Nov 20, 2024

BigTest Unit Test Statistics

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ±0 

Results for commit 30aa625. ± Comparison against base commit 805be2d.

♻️ This comment has been updated with latest results.

@alisher-epam alisher-epam merged commit 175f28a into master Nov 21, 2024
6 checks passed
@alisher-epam alisher-epam deleted the revert-UIREC-393 branch November 21, 2024 20:28
usavkov-epam pushed a commit that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants