Skip to content

Commit

Permalink
Properly rationalize the requirement for "Version " prefix in NameID 5
Browse files Browse the repository at this point in the history
The prefix seems redundant, so it should be properly explained why it is a hard requirement. (PR #4868)
  • Loading branch information
rimas-kudelis authored Oct 22, 2024
1 parent 3edb21e commit b4a2c8b
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions Lib/fontbakery/checks/vendorspecific/googlefonts/name.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,7 @@ def check_name_description_max_length(ttFont):
For Google Fonts, the version string must be in the format "Version X.Y".
The version number must be greater than or equal to 1.000. (Additional
information following the numeric version number is acceptable.)
The "Version " prefix is a recommendation given by the OpenType spec.
""",
proposal="https://github.com/fonttools/fontbakery/issues/4829", # legacy check
)
Expand All @@ -99,6 +100,8 @@ def is_valid_version_format(value):
f" (nameID={NameID.VERSION_STRING}) value must"
f' follow the pattern "Version X.Y" with X.Y'
f" greater than or equal to 1.000."
f' The "Version " prefix is a recommendation'
f" given by the OpenType spec."
f' Current version string is: "{ventry}"',
)

Expand Down

0 comments on commit b4a2c8b

Please sign in to comment.