Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rationale wording is opposite of what the check actually does #4744

Conversation

jenskutilek
Copy link
Contributor

@jenskutilek jenskutilek commented May 27, 2024

Description

Relates to issue #4743

Checklist

  • update CHANGELOG.md
  • wait for the tests to pass
  • request a review

@jenskutilek jenskutilek linked an issue May 27, 2024 that may be closed by this pull request
@simoncozens
Copy link
Collaborator

Yep, sorry. LGTM.

@felipesanches felipesanches merged commit 4a11113 into main May 28, 2024
57 checks passed
@jenskutilek jenskutilek deleted the 4743-comgooglefontscheckoutline_direction-contradictory-wording branch May 28, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[com.google.fonts/check/outline_direction] Contradictory wording
3 participants