Speed up expected_font_names #4765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simoncozens
force-pushed
the
expected-name-speedup
branch
from
e05dd3c
to
7f9e215
Compare
felipesanches
pushed a commit
that referenced
this pull request
Jun 13, 2024
In expected_font_names we do a deep copy of the font because we're going to modify it and we don't want to mess up further tests. But for big fonts this is very slow, and we use expected_font_names a few times. We don't need glyf and gvar and GPOS and everything else to work out what names the font should have. Instead, let's only copy the tables that we need to run build_name_table. (PR #4765)
felipesanches
force-pushed
the
expected-name-speedup
branch
from
7f9e215
to
a434264
Compare
In expected_font_names we do a deep copy of the font because we're going to modify it and we don't want to mess up further tests. But for big fonts this is very slow, and we use expected_font_names a few times. We don't need glyf and gvar and GPOS and everything else to work out what names the font should have. Instead, let's only copy the tables that we need to run build_name_table. (PR #4765)
felipesanches
force-pushed
the
expected-name-speedup
branch
from
a434264
to
6c4b78c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In
expected_font_nameswe do a deep copy of the font because we're going to modify it and we don't want to mess up further tests. But for big fonts this is very slow, and we useexpected_font_namesa few times. We don't needglyfandgvarandGPOSand everything else to work out what names the font should have. Instead, let's only copy the tables that we need to runbuild_name_table.Checklist
CHANGELOG.md